Add support to pass clone options that can be repeated multiple times #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It appears that the tests that are failing were failing prior to my change so I don't think my change is a regression. |
Codecov Report
@@ Coverage Diff @@
## master #836 +/- ##
==========================================
- Coverage 94.79% 94.67% -0.12%
==========================================
Files 59 59
Lines 9603 9398 -205
==========================================
- Hits 9103 8898 -205
Misses 500 500
Continue to review full report at Codecov.
|
|
Thanks a lot for your contribution! It's very much appreciated :)! |
|
I am closing this PR as due to me apparently making a mistake while merging things locally, Github is unable to see the branch has actually been merged. Your commit is here 41b9cea |
|
Thanks for accepting the change.
- Steve -
…On Fri, Jul 5, 2019 at 11:23 PM Sebastian Thiel ***@***.***> wrote:
Closed #836 <#836>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#836?email_source=notifications&email_token=ADNQAORGVVEMOT5UE7ICGLDP6AF4VA5CNFSM4GUHLHR2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOSLM6HAI#event-2463753089>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADNQAOT6EX3NAILEKMKQCSTP6AF4VANCNFSM4GUHLHRQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #824, allowing options to be passed directly without additional processing by the underlying framework.